Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stratification of violin plot based on sample sets #1793

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

keller-mark
Copy link
Member

@keller-mark keller-mark commented Jan 31, 2024

Fixes #1782
Fixes #1774
Fixes #1776
Fixes #1040
Closes #1383

TODO:

  • dot plot
  • dot plot stratified by sample set (example)
  • Use colormap from coordination space for mean expression colormap
  • Normalized expression for dot plot - use normalization layer from cellxgene object
  • Colors of sample sets
  • Stratify/Filter single-cell vs. single-nucleus (or toggle)
  • Add sampleSets and sampleEdges to anndataZarrSchema
  • Vitessce should not crash when second-level sample set is selected
  • Vitessce should not crash when 1 or 3+ sample sets are selected (As opposed to 0 or 2)

Background

Change List

Checklist

  • Ensure PR works with all demos on the dev.vitessce.io homepage
  • Open (draft) PR's into vitessce-python and vitessce-r if this is a release PR
  • Documentation added or updated

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Size Change: +15.9 kB (+0.11%)

Total Size: 14.2 MB

Filename Size Change
./packages/main/prod/dist/index-********.js 8.22 MB +15.8 kB (+0.19%)
ℹ️ View Unchanged
Filename Size Change
./packages/main/prod/dist/blosc-********.js 612 kB 0 B
./packages/main/prod/dist/browser-********.js 16.2 kB 0 B
./packages/main/prod/dist/chunk-INHXZS53-********.js 558 B 0 B
./packages/main/prod/dist/deflate-********.js 244 B 0 B
./packages/main/prod/dist/gzip-********.js 693 B 0 B
./packages/main/prod/dist/hglib-********.js 4.33 MB 0 B
./packages/main/prod/dist/index.min.js 964 B +37 B (+3.99%)
./packages/main/prod/dist/jpeg-********.js 15.3 kB 0 B
./packages/main/prod/dist/lerc-********.js 47.2 kB 0 B
./packages/main/prod/dist/lz4-********.js 43.9 kB 0 B
./packages/main/prod/dist/lzw-********.js 2.11 kB 0 B
./packages/main/prod/dist/packbits-********.js 577 B 0 B
./packages/main/prod/dist/pako.esm-********.js 68.6 kB 0 B
./packages/main/prod/dist/raw-********.js 169 B 0 B
./packages/main/prod/dist/troika-three-text.esm-********.js 182 kB 0 B
./packages/main/prod/dist/webimage-********.js 837 B 0 B
./packages/main/prod/dist/zlib-********.js 695 B 0 B
./packages/main/prod/dist/zstd-********.js 643 kB 0 B

compressed-size-action

Base automatically changed from keller-mark/sample-support to main March 4, 2024 13:53
@keller-mark keller-mark marked this pull request as ready for review May 24, 2024 20:41
Copy link
Contributor

github-actions bot commented May 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.11% 11127 / 14814
🔵 Statements 75.11% 11127 / 14814
🔵 Functions 63.02% 300 / 476
🔵 Branches 79.38% 1028 / 1295
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/constants-internal/src/constants.ts 100% 100% 100% 100%
packages/main/all/src/base-plugins.ts 100% 100% 100% 100%
packages/main/all/src/joint-file-types.ts 47.71% 64.51% 66.66% 47.71% 22-23, 43-44, 50-58, 62-68, 72-78, 82-88, 102-108, 143-154, 171-182, 197-204, 210-285
packages/utils/sets-utils/src/cell-set-utils.js 60.05% 89.87% 51.42% 60.05% 29-30, 61-62, 125, 159-181, 203-207, 217-223, 310-327, 336-338, 384-390, 406-425, 441-460, 475-491, 507-525, 528-570, 603, 635-651, 676-691, 694-720, 723-751, 754-768, 771-796
packages/view-types/statistical-plots/src/expr-hooks.js 88.59% 72.97% 83.33% 88.59% 119, 132-135, 155-156, 194-221
Generated in workflow #3618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant