Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): upgrade view configs to use 0.0.34 data #1371

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ilan-gold
Copy link
Collaborator

Background

Upgrades view configs to use new data.

Change List

Checklist

  • Ensure PR works with all demos on the dev.vitessce.io homepage
  • Open (draft) PR's into vitessce-python and vitessce-r if this is a release PR
  • Documentation added or updated

@keller-mark
Copy link
Member

It appears cellxgene changed obs/ethnicity to obs/self_reported_ethnicity in the anndata object

@ilan-gold
Copy link
Collaborator Author

ah ok @keller-mark I haven't gotten test these out yet completely, but if you approve, I'll have a look and we can get this in if you want.

@ilan-gold ilan-gold marked this pull request as ready for review December 14, 2022 15:47
@keller-mark
Copy link
Member

I tested them out (tried clicking a gene/feature in every demo that was modified in the PR) but don't think we necessarily need to rush to get them in before #1365

@ilan-gold
Copy link
Collaborator Author

Yeah so kuppe has a broken gene (at least one) for ATAC: AC138969.4

@ilan-gold
Copy link
Collaborator Author

Ok yes I will need to re-generate kuppe with a shared var index as well.

@ilan-gold
Copy link
Collaborator Author

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants