Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple response types to @paginate decorator #1148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benjaoming
Copy link
Contributor

Fixes #940

I won't have more time to work on this one :/ I was working on this for a prototype, suggesting to use django-ninja and I wanted to be able to give feedback about how easy it can be to add features to django-ninja that might still be missing, given that it's still a relatively new project. I found that the codebase was easy to navigate and find the right places to add the feature.

Would a more ninja-skilled developer be able to push this over the finish line?

@benjaoming benjaoming changed the title Pagination multiple response types Add support for multiple response types to @paginate decorator May 2, 2024
@pmdevita
Copy link

pmdevita commented May 7, 2024

This may be a duplicate of #1028

@benjaoming benjaoming force-pushed the pagination-multiple-response-types branch from 7f04bcb to 9b5adac Compare May 7, 2024 17:59
@benjaoming
Copy link
Contributor Author

@pmdevita interesting that the approach was almost identical.

@benjaoming
Copy link
Contributor Author

Using updated @paginate for my case has worked well.

I'm happy to add some tests from #1028 if this PR looks good to continue with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom pagination for multiple response types?
2 participants