Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getCanvasContainer to types #2356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add getCanvasContainer to types #2356

wants to merge 1 commit into from

Conversation

georgemoon
Copy link

Both MapLibre GL and Mapbox GL have a function 'getCanvasContainer':

I would like to suggest that it be added to the types if possible. The attached is a simple pull request adding this type.

Thanks!

Pessimistress
Pessimistress requested changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@Pessimistress Pessimistress left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type is only used for internal type check. Map methods that are exposed to the user come from @types/mapbox-gl or maplibre-gl.

@georgemoon
Copy link
Author

The type was being exposed in the context of using "useControl" from "react-map-gl/maplibre".
I can see if I can do a minimal replication of the bug if that would be useful?

@Pessimistress
Copy link
Collaborator

I see. Yes, that would be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgemoon @Pessimistress