Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(loader-utils): Preparing to migrate from FileProviders to ReadableFiles #3000

Merged
merged 2 commits into from May 15, 2024

Conversation

dariaterekhova-actionengine
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Maybe outline your migration strategy in the PR comment?
  • I mostly see a rename of an interface, would be good to understand how this will help the next step.

@dariaterekhova-actionengine
Copy link
Collaborator Author

The main purpose of this PR is to give an instrument to use ReadableFile in already existing code (newFileProvider implementation) and give an opportunity to use both old FileProviders and new ReadableFile implementations in the same time (FileProviderInterface), so we can migrate one old FileProvider at a time.

First I'm going to correct my implementation of slpk-via-rangerequests in another PR to use already existing HttpFile instead of new code

@dariaterekhova-actionengine dariaterekhova-actionengine merged commit d9db370 into master May 15, 2024
1 check failed
@dariaterekhova-actionengine dariaterekhova-actionengine deleted the dt/file_provider_preparing branch May 15, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants