Add progress to parseShapefileInBatches.
#2073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies `zipBatchIterators` to return an object with keys `progress` and `data` rather than an array.
kylebarron
approved these changes
Feb 2, 2022
| @@ -1,3 +1,8 @@ | |||
| type Batch = { | |||
| data: number[] | number[][]; | |||
There was a problem hiding this comment.
Why the union? Seems like you'd only need one type?
| return null; | ||
| } | ||
|
|
||
| // Non interleaved arrays | ||
| const batch: number[][] = [batch1.slice(0, batchLength), batch2.slice(0, batchLength)]; | ||
| const result: any = { |
There was a problem hiding this comment.
Should this be result: Batch?
Closed
|
I'm grooming my backlog and closing stale PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work in #1105. This modifies
zipBatchIteratorsto return an object with keysprogressanddatarather than an array so we can return parsing progress for theparseShapefileInBatchesfunction.This will be useful for returning a progress indicator in a UI when loading large shapefiles.