Viosock: Remove Coinstaller Stuff from the INF File #1064
Conversation
MartinDrab
force-pushed
the
feature/viosock/remove-coinstaller
branch
from
175e5cf
to
f6c448c
Compare
|
Is the protocol not registered? |
|
It is not. I think the INFs were not responsible for registering it even before this PR (I did not notice such registrations). I can of course test this (old INFs) on a fresh machine. |
|
[VirtioSocket_Device_CoInstaller_AddReg] |
Ah, OK, I missed that. I will improve the PR. |
| @@ -26,7 +26,7 @@ DriverPackageDisplayName = %VirtioSocket.DeviceDesc% | |||
| PnpLockdown = 1 | |||
|
|
|||
| [DestinationDirs] | |||
| DefaultDestDir = 12 | |||
| DefaultDestDir = 13 | |||
| VirtioSocket_Lib_CopyFiles = 11 | |||
There was a problem hiding this comment.
According to https://learn.microsoft.com/en-us/windows-hardware/drivers/develop/run-from-driver-store#other-files, you should also move VirtioSocket_Lib_CopyFiles to 13. Please check if is this possible or not. This does not work for RNG providers.
There was a problem hiding this comment.
I will look into it, thanks. Yes, I know about RNG.
There was a problem hiding this comment.
@MartinDrab Please look into changes in #1075
HLK for 2022 and attestation signing fails with DIRID13 and without TargetOS decoration
MartinDrab
changed the title
Signed-Off-By: Martin Drab <martin.drab@virtuozzo.com>
MartinDrab
force-pushed
the
feature/viosock/remove-coinstaller
branch
from
9191b70
to
cf7e51a
Compare
…irectory Signed-Off-By: Martin Drab <martin.drab@virtuozzo.com>
Signed-Off-By: Martin Drab <martin.drab@virtuozzo.com>
MartinDrab
force-pushed
the
feature/viosock/remove-coinstaller
branch
from
cf7e51a
to
78422de
Compare
Signed-Off-By: Martin Drab <martin.drab@virtuozzo.com>
MartinDrab
changed the title
MartinDrab
force-pushed
the
feature/viosock/remove-coinstaller
branch
from
aff12c4
to
96d9493
Compare
Let's test how well this passes through HCK/HLK. If this approach proves working, let's add an installer app and an Uninstall key. Signed-Off-By: Martin Drab <martin.drab@virtuozzo.com>
MartinDrab
force-pushed
the
feature/viosock/remove-coinstaller
branch
from
96d9493
to
33760a4
Compare
| @@ -56,6 +55,15 @@ WdfCoInstaller$KMDFCOINSTALLERVERSION$.dll = 1 ; make sure the number matches wi | |||
| [VirtioSocket_Device.NT] | |||
| CopyFiles=Drivers_Dir,VirtioSocket_Lib_CopyFiles | |||
|
|
|||
| [VirtioSocket_Device.10.0.15063.Software] | |||
| AddSoftware=WSKWSP,,VirtioSocket_Software | |||
There was a problem hiding this comment.
-
How do you expect to sign this driver for Windows Server 2016? After applying a Cumulative Update for Windows Server 2016 for x64-based Systems (KB4598243), the latest OS Build is 14393.4169.
-
According to https://learn.microsoft.com/en-us/windows-hardware/drivers/install/inf-addsoftware-directive:
Each AddSoftware directive describes the installation of standalone software. This directive should be used in an INF file of the **SoftwareComponent** setup class.
How will this work in this INF withClass=System?
| SoftwareType=1 | ||
| SoftwareBinary=viosocklib-test.exe | ||
| SoftwareArguments="/i" | ||
| SoftwareVersion=1.0.0.0 |
There was a problem hiding this comment.
Should this version be equal to the driver version or the binary version?
The driver is installed in the Driver Store (DIRID 13) instead of the System Drivers directory (DIRID 12).