Avatar auto scale: match avatar eye height to user eye height. #942

Phil-Palmer · 2020-12-28T15:33:10Z

This PR adds a 'Real Height' button to the avatar scale slider. The button scales the avatar so that its eye height matches the user's real-world eye height (derived from the 'User real world height' setting). In this way, the world is displayed at 1:1 scale to the user in VR (fixes #939).

Tests done

In VR, kneel to position your head as if you were 1m tall.
Set 'User real-world height' to 1m (in Settings > Controls).
Open the Avatar app and choose the default avatar, or one with a height similar to the default avatar.
Click on the sliders icon at the top-right.
Click the '1x' scale button and observe that the world is miniaturised because the avatar is bigger than the user.
Click the 'Real Height' scale button and observe that the world is displayed at actual size (1:1 scale) because the avatar scale is matched to the user's height.

Screenshots

This adds an 'Auto' button to the avatar scale slider. The Auto button scales the avatar so that its eye height matches the user's real-world eye height (based on the 'User real world height' setting). In this way, the world is displayed at exactly 100% scale to the user in VR. The '1x' button now sets the avatar scale to 1.0 even if the current scale is at the same 'notch' as 1.0 on the scale slider (previously it had no effect in that situation). Test done: - In VR, kneel to position your head as if you were 1m tall. - Set 'User real-world height' to 1m (in Settings > Controls). - Open the Avatar app and click on the sliders icon at the top-right. - Click the '1x' button and observe that the world is miniaturised. - Click the 'Auto' button and observe that the world is displayed at actual size.

vircadia-build-notifier · 2020-12-29T00:44:56Z

The following links are available:
build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR942/Vircadia-Alpha-PR942-9fc8a1e_597cc07f.dmg

build (ubuntu-18.04, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR942/Vircadia-Alpha-PR942-9fc8a1e_597cc07f.exe

interface/src/avatar/MyAvatar.cpp

interface/src/avatar/MyAvatar.h

Improve comments and fix bracing style. Co-authored-by: David Rowe <david@ctrlaltstudio.com>

vircadia-build-notifier · 2020-12-29T11:54:31Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR942/Vircadia-Alpha-PR942-72e3793_63c3121f.dmg

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR942/Vircadia-Alpha-PR942-72e3793_63c3121f.exe

build (ubuntu-18.04, android)

Phil-Palmer · 2020-12-29T12:10:10Z

Thanks for the changes @ctrlaltdavid - I committed them.

I think the button label "Auto" would be unclear. What would you think of this instead?

JulianGro · 2020-12-29T12:54:07Z

Personally I think "Real Height" would be more descriptive. Not sure if there is space for that though. Maybe putting the "1x" on the right would make enough space?

ctrlaltdavid · 2020-12-29T19:07:22Z

Julian's suggestion sounds good to me.

as suggested here: vircadia#942 (comment)

Phil-Palmer · 2020-12-29T23:07:58Z

Thanks, I renamed the button "Real Height" in e89e80d :

…almer/project-athena into feature/avatar-auto-scale

vircadia-build-notifier · 2020-12-30T01:00:40Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR942/Vircadia-Alpha-PR942-47891ec_5acb41ab.dmg

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR942/Vircadia-Alpha-PR942-47891ec_5acb41ab.exe

build (ubuntu-18.04, android)

Phil-Palmer · 2021-01-05T19:39:10Z

@ctrlaltdavid, @JulianGro
I'm thinking it would be neater to postpone this feature until I've fixed another avatar scale problem:

If I choose an avatar taller than [the default avatar?], it squats to my eye level instead of standing straight. The workaround is to reduce my real-world height a little.
Presumably if I chose an avatar shorter than [the default avatar?], it would hang from my head or pull my viewpoint closer to the floor, depending on my recentre setting.

Originally posted by @Phil-Palmer in #939 (comment)

It should be easier to communicate the combined result of the two fixes together, rather than releasing them separately.
Does that sound good to you? If so, what should I do with this PR? Mark it as a draft / 'do not merge'?
Thanks!

digisomni · 2021-01-07T21:24:25Z

Marking it as draft will be fine for the moment. :)

Penguin-Guru · 2021-11-22T03:42:13Z

This seems like a good feature. About the button text-- I think "real height" is fine but what about "user height"? The user is the actual point of reference, although technically it's the eye height and not the user/avatar height that's synced.

stale · 2022-05-21T05:29:52Z

Hello! Is this still an issue?

digisomni added allow-build-upload Allows the upload of a build for non white-listed users enhancement New feature or request labels Dec 28, 2020

digisomni added this to In progress in 2021.1.0 Eos Release via automation Dec 28, 2020

digisomni added this to the 2021.1.0 Release milestone Dec 28, 2020

Remove unnecessary new line in avatarapp/Settings.qml

597cc07

ctrlaltdavid added needs CR (code review) needs testing (QA) The PR is ready for testing scripting api change Change is made in the scripting API labels Dec 29, 2020

2021.1.0 Eos Release automation moved this from In progress to Review in progress Dec 29, 2020

ctrlaltdavid requested changes Dec 29, 2020

View reviewed changes

interface/src/avatar/MyAvatar.cpp Outdated Show resolved Hide resolved

interface/src/avatar/MyAvatar.cpp Outdated Show resolved Hide resolved

interface/src/avatar/MyAvatar.h Outdated Show resolved Hide resolved

interface/src/avatar/MyAvatar.h Outdated Show resolved Hide resolved

Apply suggestions from code review

63c3121

Improve comments and fix bracing style. Co-authored-by: David Rowe <david@ctrlaltstudio.com>

Phil-Palmer mentioned this pull request Dec 29, 2020

World scale is unnatural unless user height equals avatar height #939

Open

2021.1.0 Eos Release automation moved this from Review in progress to Reviewer approved Dec 29, 2020

ctrlaltdavid approved these changes Dec 29, 2020

View reviewed changes

ctrlaltdavid added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Dec 29, 2020

Rename new avatar 'Auto' scale button to 'Real Height'

e89e80d

as suggested here: vircadia#942 (comment)

Merge branch 'feature/avatar-auto-scale' of https://github.com/Phil-P…

5acb41a

…almer/project-athena into feature/avatar-auto-scale

Phil-Palmer marked this pull request as draft January 7, 2021 22:40

digisomni removed this from the 2021.1.0 Release milestone Jan 27, 2021

digisomni added this to the 2021.1.1 Release milestone Jan 27, 2021

digisomni removed this from Reviewer approved in 2021.1.0 Eos Release Jan 27, 2021

digisomni added this to In progress in 2021.1.1 Eos Release via automation Jan 27, 2021

ctrlaltdavid removed needs testing (QA) The PR is ready for testing CR Approved At least one code reviewer has approved the PR. labels Feb 28, 2021

digisomni modified the milestones: 2021.1.1 Eos Release, 2021.1.2 Eos Release Mar 27, 2021

digisomni removed this from In progress in 2021.1.1 Eos Release Mar 27, 2021

digisomni added this to In progress in 2021.1.2 Eos Release via automation Mar 27, 2021

digisomni removed this from In progress in 2021.1.2 Eos Release May 28, 2021

digisomni added this to In progress in 2022.1.0 Selene Release via automation May 28, 2021

digisomni modified the milestones: 2021.1.2 Eos Release, 2021.2.0 Selene Release May 28, 2021

digisomni removed this from In progress in 2022.1.0 Selene Release Oct 30, 2021

digisomni added this to In progress in 2022.1.1 Selene Release via automation Oct 30, 2021

digisomni modified the milestones: 2021.2.0 Selene Release, 2021.2.1 Selene Release Oct 30, 2021

digisomni added the dormant This PR is on hold but has interest/use surrounding it. label Nov 6, 2021

stale bot added the stale Issue / PR has not had activity label May 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avatar auto scale: match avatar eye height to user eye height. #942

Avatar auto scale: match avatar eye height to user eye height. #942

Phil-Palmer commented Dec 28, 2020 •

edited

vircadia-build-notifier commented Dec 29, 2020

vircadia-build-notifier commented Dec 29, 2020

Phil-Palmer commented Dec 29, 2020

JulianGro commented Dec 29, 2020

ctrlaltdavid commented Dec 29, 2020

Phil-Palmer commented Dec 29, 2020 •

edited

vircadia-build-notifier commented Dec 30, 2020

Phil-Palmer commented Jan 5, 2021 •

edited

digisomni commented Jan 7, 2021

Penguin-Guru commented Nov 22, 2021

stale bot commented May 21, 2022

Avatar auto scale: match avatar eye height to user eye height. #942

Are you sure you want to change the base?

Avatar auto scale: match avatar eye height to user eye height. #942

Conversation

Phil-Palmer commented Dec 28, 2020 • edited

Tests done

Screenshots

vircadia-build-notifier commented Dec 29, 2020

vircadia-build-notifier commented Dec 29, 2020

Phil-Palmer commented Dec 29, 2020

JulianGro commented Dec 29, 2020

ctrlaltdavid commented Dec 29, 2020

Phil-Palmer commented Dec 29, 2020 • edited

vircadia-build-notifier commented Dec 30, 2020

Phil-Palmer commented Jan 5, 2021 • edited

digisomni commented Jan 7, 2021

Penguin-Guru commented Nov 22, 2021

stale bot commented May 21, 2022

Phil-Palmer commented Dec 28, 2020 •

edited

Phil-Palmer commented Dec 29, 2020 •

edited

Phil-Palmer commented Jan 5, 2021 •

edited