Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the HiFiAC codec #762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daleglass
Copy link
Contributor

This is a proprietary codec and it's uncertain who can use it, and
under what conditions. At this point, Opus is stable and a suitable
replacement.

This is a proprietary codec and it's uncertain who can use it, and
under what conditions. At this point, Opus is stable and a suitable
replacement.
@two-one-five
Copy link
Contributor

I agree, though generally I sense we should probably improve the Opus controls a bit before doing this so that people at least have some tuning in how they want to handle things?

@HifiExperiments
Copy link
Collaborator

if we have permissions to use it, it seems like we could keep this? if opus becomes the default and is configurable, that’s great, but we might have situations where the hifi codec is necessary?

@JulianGro
Copy link
Contributor

#508

@JulianGro
Copy link
Contributor

To me this is a no-brainer. We are an open-source project and if someone builds the interface, they essentially infringe the copyright of that codec.
There is no situation where HifiAC really is necessary . It is supposed to use a lot less CPU, but you can pretty much always get a bigger or a second server for that. There is also the consideration that HifiAC uses a lot higher bitrate than Opus, which might break Vircadia for people with low bandwidth internet connections.

@@ -1343,8 +1343,8 @@
"name": "codec_preference_order",
"label": "Audio Codec Preference Order",
"help": "List of codec names in order of preferred usage",
"placeholder": "opus, hifiAC, zlib, pcm",
"default": "opus,hifiAC,zlib,pcm",
"placeholder": "opus, zlib, pcm",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"placeholder": "opus, zlib, pcm",
"placeholder": "opus, zlib, pcm",

@JulianGro JulianGro linked an issue Dec 22, 2020 that may be closed by this pull request
@daleglass
Copy link
Contributor Author

Dev meeting: this is waiting on opus performance improvements

@stale
Copy link

stale bot commented May 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue / PR has not had activity label May 17, 2021
@daleglass daleglass removed the stale Issue / PR has not had activity label Aug 21, 2021
@digisomni digisomni added the dormant This PR is on hold but has interest/use surrounding it. label Nov 6, 2021
@stale
Copy link

stale bot commented May 5, 2022

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dormant This PR is on hold but has interest/use surrounding it. stale Issue / PR has not had activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vircadia is still being build with hifiAC
6 participants