Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/set avatar bookmark icons #749

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/set avatar bookmark icons #749

wants to merge 2 commits into from

Conversation

two-one-five
Copy link
Contributor

@two-one-five two-one-five commented Sep 23, 2020 •
edited by digisomni

This is a work-in-progress... still some issues such as the icon for the active bookmark not using this (easy fix) to the default icon not showing when you don't set a URL which is an empty string "".

Also AvatarApp.qml:97:5: Unable to assign [undefined] to QString shows but unsure if that started when I adjusted things or not.

Avatar App should work this way.... Try the Bookmarks.json to see if there's an icon defined there, if not, try the .fst to see if there's an icon there, if not, try the filesystem next to the avatar to see if there's an icon there, if not, just show the default icon for avatars when there is no icon found.

What this PR does: It allows you to set an icon for an avatar directly using avatar bookmarks.

@two-one-five two-one-five added the enhancement New feature or request label Sep 23, 2020
@two-one-five two-one-five added this to the 2020.3.1 Release milestone Sep 23, 2020
@two-one-five two-one-five added this to In progress in 2020.3.1 Demeter Release via automation Sep 23, 2020
@two-one-five two-one-five added this to In progress in 2020.3.3 Demeter Release via automation Oct 27, 2020
@two-one-five two-one-five removed this from In progress in 2020.3.1 Demeter Release Oct 27, 2020
@daleglass
Copy link
Contributor

The commit history looks like this needs a rebase

@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-latest, full)

build (ubuntu-18.04, full)

build (windows-latest, full)

@digisomni digisomni modified the milestones: 2020.3.3 Release, 2020.3.4 Release Dec 21, 2020
@digisomni digisomni removed this from In progress in 2020.3.3 Demeter Release Dec 21, 2020
@digisomni digisomni added this to In progress in 2020.3.4 Demeter Release via automation Dec 21, 2020
@digisomni digisomni removed this from In progress in 2020.3.4 Demeter Release Dec 28, 2020
@digisomni digisomni added this to In progress in 2021.1.0 Eos Release via automation Dec 28, 2020
@digisomni digisomni modified the milestones: 2020.3.4 Release, 2021.1.0 Release Dec 28, 2020
@digisomni digisomni removed this from In progress in 2021.1.0 Eos Release Jan 27, 2021
@digisomni digisomni added this to In progress in 2021.1.1 Eos Release via automation Jan 27, 2021
@digisomni digisomni added this to In progress in 2021.1.2 Eos Release via automation Mar 27, 2021
@digisomni digisomni removed this from In progress in 2021.1.1 Eos Release Mar 27, 2021
@digisomni digisomni removed this from In progress in 2021.1.2 Eos Release May 28, 2021
@digisomni digisomni added this to In progress in 2022.1.0 Selene Release via automation May 28, 2021
@digisomni digisomni removed this from the 2021.1.2 Eos Release milestone May 28, 2021
@digisomni digisomni added this to the 2021.2.0 Selene Release milestone May 28, 2021
@daleglass
Copy link
Contributor

@kasenvr What's the state of this one? Still needs work?

@digisomni digisomni removed this from In progress in 2022.1.0 Selene Release Jun 19, 2021
@digisomni digisomni removed this from the 2021.2.0 Selene Release milestone Jun 19, 2021
@digisomni digisomni added the postponed This will be revisited at a later time. label Jun 19, 2021
@stale
Copy link

stale bot commented Dec 16, 2021

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request postponed This will be revisited at a later time. stale Issue / PR has not had activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@two-one-five @daleglass @vircadia-build-notifier @digisomni