Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lots of build warnings #1665

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Fix lots of build warnings #1665

wants to merge 41 commits into from

Conversation

daleglass
Copy link
Contributor

With this the interface build is almost clean.

This adds a warning whitelist system -- there's some stuff we just can't fix yet because we can't upgrade Qt or OpenSSL. This also adds a way to make the build fail on warning, and this is intended to be enabled by default very soon to improve code quality.

@daleglass
Create warning whitelist system
4a20cde
@daleglass
Only whitespace changes
1fd6ae0
@daleglass
Replace deprecated toList() with values()
b01929e
@daleglass
Fix operator precedence warning
e3f0a6b
@daleglass
Replace deprecated Qt code with STL
bb067e1
@daleglass
Annotate fall-through
94dfef1
@daleglass
Rewrite outputBits without sprintf (deprecated)
37e3936
@daleglass
Replace mutex with recursive mutex (deprecated)
725fd9a
@daleglass
Replace deprecated qrand
c3e8350
@daleglass
Don't use memcpy with non-trivially-copyable type
59ecaf8
@daleglass
Remove unused variable
5e2b232
@daleglass
Fix type range comparison
8986dff
@daleglass
Replace deprecated screenCountChanged event
96137e2
@daleglass
Replace deprecated QFontMetrics.width()
756e0be
@daleglass
Replace QTime with QElapsedTimer (deprecated)
f58f0fd
@daleglass
Remove unused variable
8709d3b
@daleglass
Ensure memory is cleared to make compiler happy
e0fc1c8
@daleglass
Fix new[]/delete mismatch warning
b2d7f81
@daleglass
Replace deprecated qVariantFromValue
492ccc4
@daleglass
Fix deprecated int to flags conversion
db2d5cb
@daleglass
Fix operator precedence warning
f3ef7a4
@daleglass
Replace deprecated error() signal
b809a13
@daleglass
Fix StrongRef warning
e84481a
@daleglass
Fix signed/unsigned comparison warning
7c0415a
@daleglass
Fix writing to buffer out of bounds warning
6a9a1e1
@daleglass
Replace use of deprecated sprintf
66f70e4
@daleglass
Replace usage of deprecated QWheelEvent members
9ac338e
@daleglass
Use const reference (warning)
900f162
@daleglass
Fix writing to buffer out of bounds warning (another one)
7d8aa04
@daleglass
Fix 'warning: ‘size_t strlen(const char*)’ reading 1 or more bytes fr…
b0d8414 
…om a region of size 0 [-Wstringop-overread]'
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (windows-2019, full)

build (self-hosted_debian-11_aarch64, full)

@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (windows-2019, full)

build (self-hosted_debian-11_aarch64, full)

@digisomni digisomni added this to In progress in 2022.1.2 Release via automation Jun 21, 2022
@digisomni digisomni added this to the 2022.1.2 Selene Release milestone Jun 21, 2022
2022.1.2 Release automation moved this from In progress to Review in progress Jun 24, 2022
@daleglass @digisomni
Update libraries/shared/src/WarningsSuppression.h
737edcd 
Co-authored-by: Kalila <69767640+digisomni@users.noreply.github.com>
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-10.15, full)

build (windows-2019, full)

build (self-hosted_debian-11_aarch64, full)

ctrlaltdavid
ctrlaltdavid requested changes Jun 30, 2022
View reviewed changes
interface/src/avatar/AvatarPackager.cpp Outdated Show resolved Hide resolved
interface/src/commerce/Wallet.cpp Outdated Show resolved Hide resolved
libraries/networking/src/HMACAuth.cpp Outdated Show resolved Hide resolved
libraries/octree/src/OctreeElement.cpp Outdated Show resolved Hide resolved
libraries/shared/src/SettingHelpers.cpp Outdated Show resolved Hide resolved
libraries/shared/src/SettingHelpers.cpp Outdated Show resolved Hide resolved
libraries/workload/src/workload/Space.cpp Outdated Show resolved Hide resolved
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (windows-2019, full)

build (self-hosted_debian-11_aarch64, full)

@digisomni digisomni added the rebuild rebuild through the GithubActions label Jul 19, 2022
@stale
Copy link

stale bot commented Jan 15, 2023

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digisomni digisomni Awaiting requested review from digisomni

@ctrlaltdavid ctrlaltdavid Awaiting requested review from ctrlaltdavid

Assignees
No one assigned
Labels
needs CR (code review) needs testing (QA) The PR is ready for testing rebuild rebuild through the GithubActions stale Issue / PR has not had activity
Projects
2022.1.2 Release
Review in progress
Milestone
2022.1.2 Selene Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daleglass @vircadia-build-notifier @ctrlaltdavid @digisomni