Use Qt 5.12.3 to work around macOS issues. #1558

JulianGro · 2021-12-31T00:08:13Z

This PR works around the issues we are experiencing when mixing macOSXSDK10.12 with Qt 5.15.2.

Depends on PR #1556

Tested on macOS Big Sur

This is a proprietary codec and it's uncertain who can use it, and under what conditions. At this point, Opus is stable and a suitable replacement.

vircadia-build-notifier · 2021-12-31T04:18:28Z

The following links are available:
build (macOS-10.15, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1558/Vircadia-Interface-PR1558-4eff071-_28c736e0.dmg

build (macOS-10.15, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1558/Vircadia-PR1558-4eff071-_28c736e0.dmg

build (ubuntu-18.04, full)

build (self-hosted_debian-11_aarch64, full)

Steve-Pruneau · 2022-01-01T22:08:00Z

Oh wow! I am absolutely loving PR 1558 !!! This is the best macOS interface yet!

It is stable and movement smooth (not as much lag during loading).

This should go into production.

digisomni · 2022-01-02T19:39:11Z

Maybe before each if statement we should have a "TODO" noting that it's a hack and may not really last long term as we have to move up in Qt versions over time which includes reworking more code.

JulianGro · 2022-01-02T20:03:25Z

That would make the code even messier than it already is, and all occurrences can be found by the same if statement.
Adding something like "TODO: Remove once there is a Metal rendering backend" to ~120 if statements just seems a bit much.
Maybe someone that actually works on Qt deprecation like @daleglass could chime in.

JulianGro · 2022-01-02T20:05:09Z

We actually also have if statements like this in the code already.
So if we decide on adding TODOs, then we should add them to those as well.

ArcadeFever · 2022-01-16T19:47:55Z

Sorry for the late comment on this, but is the goal to downgrade all macOS builds or split out "Big Sur" from the mac builds to resolve Steve's issue? If this PR is doing the former, then it will break web entity support for zoom/google docs/ etc, ~~which currently work fine with newer macOS versions and Selene~~.

JulianGro · 2022-01-17T01:46:26Z

I don't see how downgrading all builds would not break web entity support while a secondary build works.

Whatever the case, this works around all the OpenGL issues. If the current client works on your mac that is fine but that is an exception. Without this PR there is crashes on startup, crashes on resizing window, and freezes on startup on most Apple machines running macOS Big Sur or newer.

ArcadeFever · 2022-01-17T03:33:31Z

So turns out I was running the release candidate for Selene on my MacBook, thus crossed out last part above. Testing with the full 2022.1.0 release it is also failing to launch for me. In fact, 2021.1.3 and 2021.1.2 also fail to launch, but 2021.1.1 works (and use the "interface" client before it was renamed to Vircadia).

The concern with downgrading QT, is it will break web entity support for certain applications like Zoom and Google Docs, so would be a step backward, but I can understand not a lot of mac users probably need this support right now.

I would think we should be investigating why the Selene RC build and 2021.1.1 (and prior) worked fine with QT 5.15.2 on mac. So I hope this PR fix to rollback QT is only temporary.

JulianGro · 2022-01-17T16:46:09Z

The concern with downgrading QT, is it will break web entity support for certain applications like Zoom and Google Docs, so would be a step backward, but I can understand not a lot of mac users probably need this support right now.

Will it break support or have you actually tested the PR?

I would think we should be investigating why the Selene RC build and 2021.1.1 (and prior) worked fine with QT 5.15.2 on mac. So I hope this PR fix to rollback QT is only temporary.

I know why some builds worked and some didn't. Try fullscreen mode on that RC build you have been using.
That is a build that was made with a different macOSXSDK.
The macOSXSDK that we need to use to work around Apples OpenGL issues doesn't work properly together with newer Qt and macOS Big Sur or higher. And with properly I mean that it doesn't work at all for me and Steve.

This PR is to gain some time. If we don't get Metal support somehow, we will eventually not be able to run on macOS anymore.

Tell accountmanager url changed

set the new MS url for Overte: https://overte.org/mvs

update federation.json with the new MS url for Overte.

Ressources rebranding for Overte (mostly images, icon, model updated with Overte brand) some file has been edited to replace some files (they had vircadia in the name) Most of this has not been tested. (cause I don't build)

Replaced by brand-logo.svg

Replaced by: logo_overte.fbx logo_overte_white-color-emissive.fst

Replaced by brand.png

Replaced by : brand-logo-512.png

…rse server address

This rebrands the resource used for the installer. Note 1: I have not upgrade the file under "launchers" directory, these are visibly not used (still High Fidelity brand) Note 2: There is one file I can't modify: "install-folder.rsrc". There is nothing to edit that on the web... this would need a mac. Note 3: there was a slogan on 2 pictures under the logo: "virtual realities for one, for all". I left this blank for now... We would need a slogan to replace tit.

New Overte logo in a better size and spacing

Adjustment for Logo ratio

This reverts commit 2400bc9.

Logo ratio adjustment

Resources Rebranding for Overte

digisomni · 2022-02-19T22:06:24Z

This PR needs to be updated from Vircadia master.

stale · 2022-08-31T02:21:07Z

Hello! Is this still an issue?

daleglass and others added 5 commits September 27, 2020 20:17

Remove the HiFiAC codec

125841a

This is a proprietary codec and it's uncertain who can use it, and under what conditions. At this point, Opus is stable and a suitable replacement.

Reinstate partial backwards compatibility with Qt 5.12.3

61ba1f3

Use Qt 5.12.3 for macOS to work around issue vircadia#1516

2275c61

Fix Qt 5.12.3 type errors

058b903

Add old Qt packages for manual selection.

28c736e

JulianGro added needs testing (QA) The PR is ready for testing needs CR (code review) macos This is related to OSX and Mac. Qt labels Dec 31, 2021

digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Jan 2, 2022

digisomni added this to In progress in 2022.1.1 Selene Release via automation Jan 2, 2022

digisomni added this to the 2022.1.1 Selene Release milestone Jan 2, 2022

digisomni requested a review from daleglass January 4, 2022 03:43

digisomni changed the title ~~Use Qt 5.12.3 to work around macOS issues~~ Use Qt 5.12.3 to work around macOS issues. Jan 4, 2022

Frost added 5 commits January 6, 2022 11:22

Add metaverse server field on the login screen

5a09064

Fix height, tabbing, and other stuff

b5258ea

Fix some anchors and add logging

3d0c5e2

Tell the AccountManager that the auth URL changed

d2f8780

Remove duplicate setAuthURL declaration

d2f0583

2022.1.1 Selene Release automation moved this from In progress to Review in progress Jan 17, 2022

ksuprynowicz and others added 20 commits January 28, 2022 19:40

Merge pull request #2 from overte-org/tell-accountmanager-url-changed

e6b78fd

Tell accountmanager url changed

update teh MS for Overte

0e69da9

set the new MS url for Overte: https://overte.org/mvs

Merge pull request #5 from AleziaKurdis/fix/OverteInFederation

79ecad6

update federation.json with the new MS url for Overte.

Ressources rebranding for Overte

f97b1df

Ressources rebranding for Overte (mostly images, icon, model updated with Overte brand) some file has been edited to replace some files (they had vircadia in the name) Most of this has not been tested. (cause I don't build)

Replace by brand-banner.svg

990b4f2

Replaced by brand-logo.svg

9b1958e

Replaced by brand-logo.svg

Delete VircadiaLogo.fbx

ae3f241

Replaced by: logo_overte.fbx logo_overte_white-color-emissive.fst

Delete vircadia.png

b10d7af

Replaced by brand.png

Delete vircadia-logo-1880.png

43b5e83

Replaced by : brand-logo-512.png

Updated some URLs, rebranded documentation and changed default metave…

c6f1e64

…rse server address

Replaced the rest of metaverse addresses

1ab6f17

Merge remote-tracking branch 'origin/master' into overte_rebranding

55dac33

New Overte logo in a better size and spacing

026cc62

New Overte logo in a better size and spacing

Fix server-console and ICE server address

1191168

Adjustment for Logo ratio

2400bc9

Adjustment for Logo ratio

Revert "Adjustment for Logo ratio"

bd457cc

This reverts commit 2400bc9.

Logo ratio adjustment

ceb5456

Logo ratio adjustment

Merge pull request #13 from AleziaKurdis/overte_rebranding

7e6fcda

Resources Rebranding for Overte

Clean up Qt compatibility code

92907bd

JulianGro mentioned this pull request Feb 19, 2022

Use Qt 5.12.3 to work around macOS issues overte-org/overte#18

Closed

Merge branch 'master' into macOS_old_Qt

0e8e691

JulianGro marked this pull request as draft February 19, 2022 22:28

digisomni added do not merge do not merge due to issues or pending updates and removed QA Approved The PR has been tested successfully. needs CR (code review) labels Feb 20, 2022

JulianGro mentioned this pull request Apr 4, 2022

Use Qt 5.12.3 to work around macOS issues overte-org/overte#56

Closed

stale bot added the stale Issue / PR has not had activity label Aug 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Qt 5.12.3 to work around macOS issues. #1558

Use Qt 5.12.3 to work around macOS issues. #1558

JulianGro commented Dec 31, 2021 •

edited

vircadia-build-notifier commented Dec 31, 2021

Steve-Pruneau commented Jan 1, 2022

digisomni commented Jan 2, 2022

JulianGro commented Jan 2, 2022

JulianGro commented Jan 2, 2022

ArcadeFever commented Jan 16, 2022 •

edited

JulianGro commented Jan 17, 2022

ArcadeFever commented Jan 17, 2022

JulianGro commented Jan 17, 2022

digisomni commented Feb 19, 2022

stale bot commented Aug 31, 2022

Use Qt 5.12.3 to work around macOS issues. #1558

Are you sure you want to change the base?

Use Qt 5.12.3 to work around macOS issues. #1558

Conversation

JulianGro commented Dec 31, 2021 • edited

vircadia-build-notifier commented Dec 31, 2021

Steve-Pruneau commented Jan 1, 2022

digisomni commented Jan 2, 2022

JulianGro commented Jan 2, 2022

JulianGro commented Jan 2, 2022

ArcadeFever commented Jan 16, 2022 • edited

JulianGro commented Jan 17, 2022

ArcadeFever commented Jan 17, 2022

JulianGro commented Jan 17, 2022

digisomni commented Feb 19, 2022

stale bot commented Aug 31, 2022

JulianGro commented Dec 31, 2021 •

edited

ArcadeFever commented Jan 16, 2022 •

edited