Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linespan support #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bored-engineer
Copy link

Added the ability to exact the entire linespan for a tag, not just the line number.

@bored-engineer
Copy link
Author

Any updates on this?

@jheld
Copy link

jheld commented Jun 30, 2015

Yeah, he doesn't seem particularly interested in maintaining this. You may want to try emailing him, via his address in the AUTHORS file.

@viraptor
Copy link
Owner

viraptor commented Nov 7, 2016

Thanks for the contribution @bored-engineer ! phply is under new management now ;)
I'll try to process the linespan changes soon. Py3 patches will likely be removed, since it's implemented already in another change set.

@bored-engineer
Copy link
Author

Hey @viraptor that's great to hear! My apologies the Python 3 patches got mixed in here, wasn't my intention.

@viraptor
Copy link
Owner

viraptor commented Dec 19, 2016

@bored-engineer I'm just trying to process this patch and thinking of how to really handle linespans. As it is currently linespans will always belong to one token only. But that means that linespan of isset in:

isset(
  $a,
  $b);

is still (1,1). I guess I'd expect (1,3). Am I misunderstanding how this should work? Which version of behaviour would you expect?

(merged temporarily in https://github.com/viraptor/phply/tree/linespan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants