Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spec and fixture for rust nested test modules #713

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dyllandry
Copy link

Make sure these boxes are checked before submitting your pull request:

  • Add fixtures and spec when implementing or updating a test runner
  • Update the README accordingly
    • Didn't, I don't think necessary.
  • Update the Vim documentation in doc/test.txt
    • Didn't, I don't think necessary.

The added failing spec demonstrates the issue #708

vim-test isn't running the correct test command for rust files, with both cargo test and nextest, when tests in a single file are nested inside modules. The linked issue has an example.

@dyllandry
Copy link
Author

Some context from #708, I don't know much vimscript, but it was suggested I open a PR that adds a spec and fixture to demonstrate the problem. I managed to do that. Let me know if I can improve it.

Hopefully someone else who knows more about vim-test than I can fix the underlying issue. If no one comes by for long enough that I've learnt enough vimscript, I'll try fixing it.

@codeinabox codeinabox marked this pull request as draft February 13, 2023 15:05
@codeinabox
Copy link
Collaborator

Thank you for doing this. I am trying to figure out issues with the tests running in the pipeline and then can look into this later, though this looks great so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants