support reading package.json from non-root cwd #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeinabox
reviewed
Nov 11, 2019
| @@ -4,7 +4,8 @@ let test#javascript#patterns = { | |||
| \} | |||
|
|
|||
| function! test#javascript#has_package(package) abort | |||
| for line in readfile('package.json') | |||
| let json_path = findfile('package.json', '.;') | |||
There was a problem hiding this comment.
We should get this to exclude node_modules as that will contain main package.json files
|
Thank you for this pull request. My only reservation is we might need to update all the runners as they presume that the node_modules directory which can contain the test runner binary is in the current working directory. |
|
I guess you can use |
|
Note: |
|
This patch makes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extremely minor change to allow for reading package.json in a non root location. I am doing client work on a massive repository, and frequently will
:cdinto a project directory when I am working on it in order to have a sane fzf experience :)