Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve Vim.Buffer.read_content/edit_content #466

Merged
merged 2 commits into from
Jan 14, 2017
Merged

Fix and improve Vim.Buffer.read_content/edit_content #466

merged 2 commits into from
Jan 14, 2017

Conversation

lambdalisue
Copy link
Member

  1. Fix 'no such buffer' exception during 'read_content' (ref: Gista listすると「該当するバッファはありませんでした」とエラーが表示される。 lambdalisue/vim-gista#81 (comment))
  2. Add 'lockmarks' option to lock marks on the buffer

@lambdalisue lambdalisue changed the title Fix and improve Vim.Buffer.read_content/edit_content RFC:Fix and improve Vim.Buffer.read_content/edit_content Jan 12, 2017
@lambdalisue
Copy link
Member Author

lambdalisue commented Jan 12, 2017 •
edited

もしかして： execute 'bwipeout!' shellescape(tempfile) ってする必要が Windows の場合はあって、そのせいでエラーが出てた？（もしくは fnameescape)

もしもそうなら silent を愚直に足すべきではないので Windows の人試して頂けると助かります

@mattn
Copy link
Member

mattn commented Jan 12, 2017

vim のコマンドの時は fnameescape、外部コマンドに渡す場合は shellescape と覚えまましょう。今回の場合は fnameescape す。

@mattn
Copy link
Member

mattn commented Jan 12, 2017

ちなみに execute はエスケープ不要です。

@lambdalisue
Copy link
Member Author

なるほどやはり。ありがとうございます！修正して--forceします

@lambdalisue lambdalisue changed the title RFC:Fix and improve Vim.Buffer.read_content/edit_content Fix and improve Vim.Buffer.read_content/edit_content Jan 13, 2017
@lambdalisue
Vim.Buffer: Add 'lockmarks' option to lock marks
46ba78d
@lambdalisue
Vim.Buffer: Use 'silent' and 'fnameescape'
854ce5a 
fnameescape() is required while tempfile might contains
backslash in Windows.

silent is added while the line is for removing 'tempfile'
from unlisted-buffer which is not a core part of the
function (#439)

Fix lambdalisue/vim-gista#81
@thinca thinca merged commit a3b3044 into master Jan 14, 2017
@thinca thinca deleted the Vim-Buffer branch January 14, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinca thinca thinca approved these changes

Assignees
No one assigned
Labels
Review me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lambdalisue @mattn @thinca