Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for FLAC-in-MP4 audio tracks #272

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on May 24, 2019

  1. Cache buffer.byteLength in NalByteStream.push

    Significant speedup in (pre-Chromium) Edge, especially for high
    bitrates such as uncompressed or lightly-compressed frames.
    
    Previously, buffer.byteLength and buffer.length got looked up
    multiple times per byte processed in Edge, leading to higher
    CPU usage.
    bvibber committed May 24, 2019
    Configuration menu
    Copy the full SHA
    d17649e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2019

  1. Basic support for FLAC-in-MP4 audio tracks

    Allows for creating an MP4 stream with FLAC contents using
    the MP4 box generation functions or AudioSegmentStream.
    
    Use codec string 'fLaC' and specify a 'metadata' field in the
    track info with the FLAC METADATA_BLOCK_HEADER fields to go
    into the dfLa box.
    
    See https://github.com/xiph/flac/blob/master/doc/isoflac.txt
    for details of the MP4 embedding of FLAC audio.
    
    Also allows variable-length audio packets in AudioSegmentStream
    
    FLAC may have variable-length packets, so allow passing a
    duration in samples on incoming frames.
    
    This gets FLAC with, say, 960 samples per frame working
    consistently in Firefox and Chrome.
    bvibber committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    46e4327 View commit details
    Browse the repository at this point in the history