Skip to content

Commit

Permalink
Set MinGOP in bitmovin preset when GopMode is fixed (#331)
Browse files Browse the repository at this point in the history
* Set MinGOP in bitmovin preset when GopMode is fixed

* disable scenecut when in fixed GOP mode

Co-authored-by: Evan Sonderegger <evan.sonderegger@nytimes.comm>
Co-authored-by: Adam Sax <adam.sax@nytimes.com>
  • Loading branch information
3 people committed Oct 22, 2020
1 parent a890ee2 commit 4da72b8
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/provider/bitmovin/bitmovin.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,10 @@ func (p *bitmovinProvider) createH264VideoPreset(preset db.Preset, customData ma
return nil, err
}
h264.MaxGOP = intToPtr(int64(gopSize))
if preset.Video.GopMode == "fixed" {
h264.MinGOP = intToPtr(int64(gopSize))
h264.SceneCutThreshold = intToPtr(int64(0))
}
}
if preset.Video.BFrames != "" {
bFrames, err := strconv.Atoi(preset.Video.BFrames)
Expand Down

0 comments on commit 4da72b8

Please sign in to comment.