Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logic to skip messages belonging to archived/locked threads #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

negswell
Copy link

@negswell negswell commented Jun 25, 2022

Added the logic to skip messages that belong to threads.
Api calls will no longer be made if the message belongs to an archived/locked thread.

Note: I formatted the code using prettier.

Refer Issue : #242

@negswell negswell changed the title added logic to skip messages belonging to threads added logic to skip messages belonging to archived/locked threads Jun 25, 2022
@tbernaerd
Copy link

Not a proper developer, just wanted to try this out as it has been annoying me too. This does seem to work when there are messages in archived threads, but doesn't when there are none in the first search results.

Started at 9/17/2022, 9:45:40 PM
authorId="123" guildId="123" channelId="123" minId="" maxId="2022-09-16T21:41" hasLink=false hasFile=false
Total Archived Threads found undefined.
Messages belonging to these threads will be skipped.

@negswell
Copy link
Author

@tbernaerd hey , i din't handle the display message , but it should still continue to work nevertheless even if you get the wrong message in the output i guess , please confirm if it still fails to work as you continue.

@tbernaerd
Copy link

Hi, that's fair just wanted to report my findings. I'm trying this on a server for my own messages without a channel filter. The normal version of the script gets into an archived thread delete fail loop fairly quickly, therefore never reaching other messages to delete.

Your version seems to work when I do use the channel filter, but not when I don't. The popup with the number of messages never shows and it appears stuck.
Is there any tech info I can extract that would be helpful to solve this?

@thewriteway
Copy link

I hope this can get merged now as the use of threading is very much common place in a lot of servers.

@ghost
Copy link

ghost commented Mar 7, 2023

Hey, just implemented my own fix just atop the newer 5.1.1 version:
#457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR needs further testing PR outdated / needs rebase PR needs to be updated because it is behind master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants