Ended because API returned an empty page (Fix) #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
funny, i just forked this to write a similar fix for the same issue. merge pl0x! |
|
Is there a hope that this is fixed? |
|
I have the same problem and I have about 30,000 messages left to delete. Is this still being worked on? |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @overdosing)
|
I had this issue just now, reinstalled it & it still seemed bugged, a workaround for this is to set it to delete all messages prior to the one you started having issues with & it'll function just fine. |
|
This fix may be a bit overkill, please see PR #323 |
|
now how to fix this nothing seems to be working |
victornpb
added
the
PR missing src files (can't merge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem regarding API returning an empty page
Summary - Since everything is done in chunks of 25, if the system finds 1-25 messages it will delete them. If it finds 0 messages (but total-offset>0) it will increment the offset by 25 to skip the 25 non-deletable messages and recurse. If (total-offset <= 0) then it will still end.
Incrementing the offset by 1 each time is not ideal because you'll still be traversing huge chunks of dead messages.
I had the original problem described above earlier - I've been running this for several hours now and have deleted thousands of messages with no errors and no API-induced slowdowns.
Credit: PinkyLaRue & larryqiann
This change is