Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package compatible with charts.js 4.X #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tchiotludo
Copy link

@tchiotludo tchiotludo commented Dec 27, 2022

the library is compatible with charts.js 4.X but will failed on npm install with node 18:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: vue-chart-3@3.1.8
npm ERR! Found: chart.js@4.1.1
npm ERR! node_modules/chart.js
npm ERR!   chart.js@"^4.1.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer chart.js@"=> ^3.1.0" from vue-chart-3@3.1.8
npm ERR! node_modules/vue-chart-3
npm ERR!   vue-chart-3@"^3.1.8" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: chart.js@3.9.1
npm ERR! node_modules/chart.js
npm ERR!   peer chart.js@"=> ^3.1.0" from vue-chart-3@3.1.8
npm ERR!   node_modules/vue-chart-3
npm ERR!     vue-chart-3@"^3.1.8" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@netlify
Copy link

netlify bot commented Dec 27, 2022

Deploy Preview for vue-chart-3 failed.

Name Link
🔨 Latest commit 7b31e3b
🔍 Latest deploy log https://app.netlify.com/sites/vue-chart-3/deploys/63ab6aa11dc3b10008a56965

@tchiotludo
Copy link
Author

still the issue here, do you plan to maintain this package are we not to fork ?
Thanks for the clarification

@maxqua72
Copy link

Please fix this issue, if it's possible. It would be a pity not using charts.js 4.x. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants