Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix topics in koan AboutComparison #451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

🐛 fix topics in koan AboutComparison #451

wants to merge 3 commits into from

Conversation

peetrike
Copy link
Contributor

@peetrike peetrike commented Jun 8, 2021 •
edited

PR Summary

fixes #450

Context

Changes

  • fix topic 'It will compare values'
  • fix topic 'It returns $true only if both inputs are $true'
  • fix topic 'It may coerce values to boolean' (in context '-or')

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@peetrike peetrike marked this pull request as ready for review June 8, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviecoaster steviecoaster Awaiting requested review from steviecoaster steviecoaster is a code owner

@vexx32 vexx32 Awaiting requested review from vexx32 vexx32 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topics solved before starting in koan AboutComparison
1 participant
@peetrike