Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Avoid confusing error in koan AboutSelectObject #445

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🐛 Avoid confusing error in koan AboutSelectObject #445

wants to merge 2 commits into from

Conversation

peetrike
Copy link
Contributor

@peetrike peetrike commented May 12, 2021 •
edited

PR Summary

Fixes #444

Context

Changes

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@peetrike peetrike marked this pull request as ready for review May 12, 2021 06:54
vexx32
vexx32 approved these changes May 12, 2021
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change. Thanks for fixing this up! 💖

@vexx32
Copy link
Owner

vexx32 commented May 12, 2021

Ignore the build failures for now, I'm getting them on everything at the moment. I'm looking into it and will get it building again as soon as I can. 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviecoaster steviecoaster steviecoaster approved these changes

@vexx32 vexx32 vexx32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Koan AboutSelectObject has undesired error
3 participants
@peetrike @vexx32 @steviecoaster