New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding super-simple Handlebars.js module #35
base: gh-pages
Are you sure you want to change the base?
Conversation
I think you need to zip it into a mod.zip file, to get this into Vert.x. And is it com.getNext.handlebars or com.getNextt.handlebars ? |
Ah, whoops. com.getNextt.handelbars. If uppercase letters aren't allowed, that's a style thing you guys are imposing, because it's working locally with my camel casing. Also, there's absolutely no documentation or instructions as to how we're supposed to submit these modules, so if it is supposed to be zipped, there's no way for anyone to know this. I'm happy to change either/anything, but some documentation would be nice as well. |
Module naming is described here http://vertx.io/mods_manual.html You'll be pleased to know that in 2.0 the way modules are published is changing completely which is going to make things a lot simpler. Unfortunately docs aren't written yet. Sorry for the inconvenience. |
Ugh. I apparently can't type. com.getNextt.handlebars. Previous post had a typo ("handelbars") If all lowercase is convention, I can change it, but the docs don't specifically mention it should be :) Also, no worries on the lack of documentation - I love what you guys are doing with the platform and I'm hoping to see it keep growing in the future :) |
No probs. The docs do mention that naming follows the Java package naming rules, which are all lowercase, but if you're not from the Java world you won't know that. Fair enough! :) |
If we want to argue semantics, it says "like a Java package name", not that it follows the same convention ;) :P Should I change it or leave it as is? |
Yes please, can you make it lower case. Sorry for the hassle! |
I guess you'd still need to zip your module and change the name of the folder, too... At least I had to, to get my modules merged ;) |
I plan to build some features out for this, but at the moment, it's just a barebones Handlebars wrapper for server-side templating