Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimulcastConsumer::GetDesiredBitrate(): Choose the highest bitrate among all Producer streams #992

Merged
merged 13 commits into from
Jan 27, 2023
Merged

SimulcastConsumer::GetDesiredBitrate(): Choose the highest bitrate among all Producer streams #992

merged 13 commits into from
Jan 27, 2023

Commits on Jan 27, 2023

  1. SimulcastConsumer::GetDesiredBitrate(): Choose the highest bitrate am… 

    …ong all Producer streams

Instead of assuming that the highest simulcast stream is the one consuming highest bitrate, iterate all them and pick up the highest value.

This is because wWhen the sender enables a higher stream, initially the bitrate of it could be less than the bitrate of a lower stream. In a few seconds it will become higher. However don't report its irrelevant current bitrate in the meantime.
    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    5b12ede View commit details
    Browse the repository at this point in the history

  2. make cargo clippy happy

    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    294b6f9 View commit details
    Browse the repository at this point in the history

  3. Update and fix CHANGELOG.md

    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    7614474 View commit details
    Browse the repository at this point in the history

  4. more rust stuff

    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    bd37034 View commit details
    Browse the repository at this point in the history

  5. more

    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c438aa1 View commit details
    Browse the repository at this point in the history

  6. Fix all cargo clippy issues

    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3058819 View commit details
    Browse the repository at this point in the history

  7. Fixing Rust clippy errors wince Rust is a young language and they are… 

    … adding basic support to print things now in 2023
    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    472527c View commit details
    Browse the repository at this point in the history

  8. Add rust-toolchain.toml to prevent CI breakage due to new Rust releas… 

    …es with more lints by default
    @nazar-pc
    nazar-pc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    cba3657 View commit details
    Browse the repository at this point in the history

  9. Simplify CI and make sure it uses rust-toolchain.toml

    @nazar-pc
    nazar-pc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    73fc3a0 View commit details
    Browse the repository at this point in the history

  10. Fix platform-specific lint

    @nazar-pc
    nazar-pc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c6e6ad1 View commit details
    Browse the repository at this point in the history

  11. really?

    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    8f7ac2d View commit details
    Browse the repository at this point in the history

  12. Add required components to rust-toolchain.toml

    @nazar-pc
    nazar-pc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    4b030a7 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'improve-simulcastconsumer-getdesiredbitrate' of github.… 

    …com:versatica/mediasoup into improve-simulcastconsumer-getdesiredbitrate

# Conflicts:
#	worker/build.rs
    @ibc
    ibc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    a558fd3 View commit details
    Browse the repository at this point in the history