Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebrtc fixes and updates #944

Merged
merged 3 commits into from
Nov 4, 2022
Merged

libwebrtc fixes and updates #944

merged 3 commits into from
Nov 4, 2022

Conversation

ibc
Copy link
Member

@ibc ibc commented Nov 4, 2022

NOTE: Some changes are already present in ongoing PR #922 but it's not yet merged. CC @sarumjanuch

- Fix calculation of feedback min_pending_time in goog_cc
  - Fixes #849
  - Commit in libwebrtc: https://webrtc.googlesource.com/src/+/d65dc979b17cdc7cd359aada59e5bce8a6f1b8ce%5E%21/
-
Fix signed-to-unsigned overflow in send_side_bandwidth_estimation.cc
  - Fixes #872
  - Issue in libwebrtc: https://bugs.chromium.org/p/webrtc/issues/detail?id=14272
  - Commit in libwebrtc: https://webrtc.googlesource.com/src/+/9804aa5f6ad26a45338d685da66497c3bbd88ca6%5E%21/

NOTE: Some changes are already present in ongoing PR #922 but it's not yet merged.
@ibc ibc added the libwebrtc label Nov 4, 2022
@ibc ibc added this to the v3 updates milestone Nov 4, 2022
@ibc ibc merged commit 60f8200 into v3 Nov 4, 2022
@ibc ibc deleted the fix-some-libwebrtc-issues branch November 4, 2022 12:41
piranna pushed a commit to dyte-in/mediasoup that referenced this pull request Feb 9, 2023
- Fix calculation of feedback min_pending_time in goog_cc
  - Fixes versatica#849
  - Commit in libwebrtc: https://webrtc.googlesource.com/src/+/d65dc979b17cdc7cd359aada59e5bce8a6f1b8ce%5E%21/
-
Fix signed-to-unsigned overflow in send_side_bandwidth_estimation.cc
  - Fixes versatica#872
  - Issue in libwebrtc: https://bugs.chromium.org/p/webrtc/issues/detail?id=14272
  - Commit in libwebrtc: https://webrtc.googlesource.com/src/+/9804aa5f6ad26a45338d685da66497c3bbd88ca6%5E%21/

NOTE: Some changes are already present in ongoing PR versatica#922 but it's not yet merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

signed-to-unsigned overflow in send_side_bandwidth_estimation.cc min_pending_time should not be negative
2 participants