ObjectPoolAllocator #903
Open
ObjectPoolAllocator #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: Currently measuring the CPU time differences with pools VS new/delete. |
|
Converted to draft while re-testing re-profiling. Feel fee to try it out and review. |
Hartigan
reviewed
Sep 13, 2022
Hartigan
reviewed
Sep 30, 2022
Hartigan
reviewed
Sep 30, 2022
Hartigan
reviewed
Sep 30, 2022
Hartigan
reviewed
Sep 30, 2022
|
@Hartigan please send multiple comments as a review together rather than individually, it will reduce number of GitHub notifications everyone receives. |
ibc
reviewed
Oct 6, 2022
ibc
requested changes
Oct 6, 2022
Hartigan
approved these changes
Oct 9, 2022
|
Which is the status of this PR? |
|
It's ready to merge. It's working properly. Even though we may want to enrich he pool allocator in the future is a good starting point. |
|
Ok? |
|
Reminder: this PR needs love. |
|
Yes, it's on my TODO |
|
I'll revive this PR for the new year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extract from a bigger "Memory Optimizations" PR #675
It contains only the
ObjectPoolAllocatorpart with a few exceptions:RtpPacket::Parse()does return aRtpPacketinstance. In Memory optimizations #675 it returned a shared pointer but since shared pointers are just needed for cloned packets (for retransmission), the former method does not need to create one.RtcpCompoundPacketis left as it was. This is, a new one is created when needed (this will be enhanced in a separate PR).As per my tests I'm not seeing much difference with this and v3. There is maybe some noticeable CPU enhancement.
Please @nazar-pc , @Hartigan give it a try and instrument this if possible to see how it enhances comparing to v3. I'll do some more testing just to make sure this addition is worth it.
Performed performance unit tests:
ObjectPoolAllocator is definitely more performant as it reuses memory instead of freeing & re-allocating it.