Fix "SimulcastConsumer cannot switch layers if initial tsReferenceSpa… #500
+45
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialLayer disappears" (versatica#492) * Set tsReferenceSpatialLayer later, only after receiving an RTCP Sender Report. * Track and carry forward offset from tsReferenceSpatialLayer.
…r when currentSpatialLayer and targetSpatialLayer are the same.
|
I had an oversight in my first commit: we need to only set tsReferenceSpatialLayer when currentSpatialLayer and targetSpatialLayer are the same, in order to always maintain consistency with the conditions defined in CanSwitchToSpatialLayer(). |
|
Actually we had something a bit different in mind. Unfortunately we are not gonna be able to review this PR no our planned approach for a while. Will notify here when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tialLayer disappears" (#492)