Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: call parent method explicitly #1384

Merged
merged 4 commits into from Apr 30, 2024
Merged

Fix: call parent method explicitly #1384

merged 4 commits into from Apr 30, 2024

Conversation

liuzhenyilang
Copy link
Contributor

Call parent method explicitly, make the code easier to understand.

ibc
ibc reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add dots at the end of comments as everywhere else.

worker/src/RTC/RtpStreamRecv.cpp Outdated Show resolved Hide resolved
worker/src/RTC/RtpStreamSend.cpp Outdated Show resolved Hide resolved
@liuzhenyilang
Copy link
Contributor Author

Please add dots at the end of comments as everywhere else.

ok

@ibc
Copy link
Member

ibc commented Apr 29, 2024

NOTE: Dots not added yet.

@liuzhenyilang
Copy link
Contributor Author

NOTE: Dots not added yet.

Sorry, forget to commit.

@ibc ibc merged commit ecb507e into versatica:v3 Apr 30, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liuzhenyilang @ibc