Run verrazzano-api pod as non root user #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmhopkins
reviewed
Apr 13, 2021
| @@ -367,16 +365,16 @@ spec: | |||
| items: | |||
| - key: startup.sh | |||
| path: startup.sh | |||
| mode: 0744 | |||
| mode: 0755 | |||
There was a problem hiding this comment.
Why are we adding execute permission for group+world?
There was a problem hiding this comment.
when the config map containing these scripts is mounted at /api-config, everything is owned by root. I tried specifying a securityContext section with runAsUser id 101 (the nginx default user www-data) but still everything mounted is owned by root:root. The www-data user is not a member of root group but needs to execute the scripts mounted from the config map.
| @@ -342,9 +343,6 @@ spec: | |||
| labels: | |||
| app: {{ .Values.api.name }} | |||
| spec: | |||
| securityContext: | |||
There was a problem hiding this comment.
If we delete the "run as user/group 0", what uid/gid does nginx run as?
There was a problem hiding this comment.
It runs by default as user id 101 which is www-data:www-data - here is their Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run verrazzano-api pod as non-root user. This required changing the default prefix path to a location that the nginx user has permissions to, and changing the permissions on some of the startup shell scripts, since those are owned by root.
Note: I tried to fix fluentd to not run as root, but from what I can gather, it needs root permission to read /var/log. Found some info here and here
Partially Fixes VZ-2504
Checklist
As the author of this PR, I have:
Code reviewer, please confirm this PR: