False else points 4691 #4844
Open
False else points 4691 #4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or into false_else_points_4691
|
I added --main support for coverage so you shouldn't need a .cpp file any longer, see the t_cover_main.pl test for an example. |
wsnyder
reviewed
Jan 23, 2024
Comment on lines
13
to
15
| top_filename("t/t_cover_else_points.sv"); | ||
| golden_filename("t/t_cover_else_points.out"); | ||
|
|
There was a problem hiding this comment.
Suggested change
| top_filename("t/t_cover_else_points.sv"); | |
| golden_filename("t/t_cover_else_points.out"); |
use the defaults and rename your file to .v instead of .sv. Then this test passes for me.
There was a problem hiding this comment.
Ubuntu 20.04 gcc tests are still failing despite these changes.
wsnyder
reviewed
Jan 24, 2024
| # Version 2.0. | ||
| # SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0 | ||
|
|
||
| scenarios(simulator => 1); |
There was a problem hiding this comment.
Suggested change
| scenarios(simulator => 1); | |
| scenarios(vlt => 1); |
| "$Self->{obj_dir}/coverage.dat", | ||
| ], | ||
| verilator_run => 1, | ||
| ); |
There was a problem hiding this comment.
Suggested change
| ); | |
| ) if !$self->errors && !$self->skips; |
As Ubuntu 20 is failing due to a skip from needing coroutines.
There was a problem hiding this comment.
That does not seem to work locally. I am getting the following error.
- t/t_cover_else_points.v:59: Verilog $finish
Can't call method "errors" on an undefined value at t/t_cover_else_points.pl line 25.
Compilation failed in require at ./driver.pl line 842.
Line 25 is the beginning for the run command.
There was a problem hiding this comment.
My fault, should be Self, capitalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a test case to replicate issue #4691