Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline tests for integration/react-18 #65199

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 30, 2024

... and move it to react-current-version in preparation of #65058

If you want to split tests, create a separate .test file so that it's easy to find where a (failing) test is located.

There's more wrong with this test with regard to cleanup but I'm not digging into that now.

Closes NEXT-3262

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team tests labels Apr 30, 2024
@ijjk
Copy link
Member

ijjk commented Apr 30, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
buildDuration 29.7s 27.5s N/A
buildDurationCached 16.7s 14.1s N/A
nodeModulesSize 360 MB 360 MB
nextStartRea..uration (ms) 668ms 760ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.09 kB 5.09 kB N/A
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 230 B 228 B N/A
main-HASH.js gzip 31.5 kB 31.5 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 4 kB 4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
index.html gzip 526 B 526 B
link.html gzip 540 B 541 B N/A
withRouter.html gzip 523 B 525 B N/A
Overall change 526 B 526 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
edge-ssr.js gzip 94.7 kB 94.7 kB
page.js gzip 181 kB 181 kB N/A
Overall change 94.7 kB 94.7 kB
Middleware size
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
middleware-b..fest.js gzip 623 B 623 B
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.62 kB 1.62 kB
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.3 kB 94.3 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93.1 kB 93.1 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.3 kB 21.3 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 962 kB 962 kB
build cache
vercel/next.js canary vercel/next.js sebbie/inline-tests Change
0.pack gzip 1.62 MB 1.62 MB N/A
index.pack gzip 114 kB 113 kB N/A
Overall change 0 B 0 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 4dfd98f

Adds indirection when trying to find a failing test or focusing on one.

import { join } from 'path'

import cheerio from 'cheerio'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make it a e2e test and specify the version? And we can test both 18 and 19 beta?

Copy link
Member Author

@eps1lon eps1lon Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to support 18 and 19 in Next.js?

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe migrate these to test/e2e and use nextTestSetup to isolate them?

@eps1lon
Copy link
Member Author

eps1lon commented Apr 30, 2024

Do we have a project that's tracking that instead? I'm trying to land the React sync and don't want to get side-tracked in big refactoring projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants