Test & fix with helmet v7 and set as a peer dependency on ^6||^7
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md: Expect-CT is no longer part of Helmet. If you still need it, you can use the expect-ct package. See #378
So that consuming projects can install specific past or future helmet versions v6 or v7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to pull in the most recent version of helmet, test updating to Helmet latest (v7).
In order to allow further updates to Helmet in future set as a peer dependency.
Set peer dependency for ^7 for current and tested Helmet v7.
Set to peer dependency
|| ^6to back-compatibly support Helmet v6 in case that is needed.The fix for Helmet v7 required removal of
helmet.expectCt()From https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md: