Fix Vulkan validation issue with uniform shader memory barriers #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous pull request #530 accidentally introduced a Vulkan validation error (sorry about that). This pull request resolves the Vulkan validation error by adjusting the scope of uniform buffer copies to comply with the Vulkan spec. The behaviors of all other buffer copies are unchanged.
Specifically, this changes the destination operation in the memory barrier to cover all shader types instead of reading the vertex input (the Vulkan spec only allows combining
UNIFORM_READ_BIT
with the shader scopes, not with the vertex input scope). It also removesVertexAttributeRead
as a destination access mask for uniform buffers as that combination is not permitted by the spec.Altogether, this treats the copy to a uniform buffer in a separate way from other buffer copies in such a way that ensures correct order of operations when a uniform buffer is updated, while also remaining compliant with the Vulkan spec.