Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix D3D11 prematurely disposing swapchain framebuffer texture #494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frenzibyte
Copy link
Contributor

This is split from #363 to revive the PR while reducing the scope of the changes, and also includes a fix for the original changes as not disposing the texture at all results in a fatal error when calling ResizeBuffers on the next swapchain resize call.

@bdach
Copy link

bdach commented Apr 2, 2023

Note for posterity: if this is applied on top of #485, then the two changes will not combine correctly despite not having merge conflicts. The undisposed swapchain framebuffer texture must be disposed before the swapchain is recreated to enable/disable tearing - otherwise mutating the AllowTearing flag will result in a crash due to an access violation.

Just figure it's better to mention it, since we're using both patches in our fork and just stumbled on this ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants