Use flip model for D3D11 swapchains #484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
frenzibyte
reviewed
Aug 30, 2023
src/Veldrid/D3D11/D3D11Util.cs
Outdated
Comment on lines
9
to
16
| /// <summary> | ||
| /// Returns the given parent of a <see cref="IDXGIObject"/>, or null if no such object exists. | ||
| /// </summary> | ||
| public static T GetParentOrNull<T>(this IDXGIObject dxgiObject) where T : ComObject | ||
| { | ||
| // Importantly, this uses the overload with an out value, which itself returns the object. | ||
| return dxgiObject.GetParent(out T obj).Success ? obj : null; | ||
| } |
There was a problem hiding this comment.
For what it's worth, on iOS, this method results in the AOT toolchain to crash at compilation time. Inlining to usages fixes that.
There was a problem hiding this comment.
Ah yes, thanks for the reminder. Totally forgot about that.
smoogipoo
force-pushed
the
d3d-flip-mode
branch
from
2ee2f45
to
e76e14f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented here, here and here, the flip model has performance advantages compared to the blt model.