Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix few issues with Metal on iOS #482

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

frenzibyte
Copy link
Contributor

While trying to run Metal on iOS, I've came across a list of issues all of which are resolved in this PR. I've separated each fix to its own commit.

  • 7f1d7c8: Similar to fa6481f, CGRect is too large to use objc_msgSend for, therefore objc_msgSend_stret is used. That being said, objc_msgSend_stret is not available on ARM64 devices, so both are used depending on the process architecture.
  • 6a7ab9e: Loading native library on iOS is not supported, and not passing a metaclass pointer at all doesn't look to break anything as far as I've checked, therefore I suppose it's fine to keep it null?
  • c136871: Applying a native scale to CAMetalLayer.drawableSize causes the application to actually be descaled by the same factor instead. Removing the scale factor fixes the issue, and macOS doesn't do it at all in the first place.

dtatarnikov added a commit to dtatarnikov/veldrid that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant