Build on mac and initialize MoltenVK #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellinoe
reviewed
Nov 4, 2022
| @@ -506,6 +506,20 @@ private void CreateInstance(bool debug, VulkanDeviceOptions options) | |||
| } | |||
| else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) | |||
| { | |||
| // The new MoltenVK now requires the following code | |||
There was a problem hiding this comment.
mellinoe
reviewed
Nov 4, 2022
src/Veldrid/Vk/VkGraphicsDevice.cs
Outdated
| // Vulkan.RawConstants.VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR | ||
| // does not exist | ||
| // | ||
| // #define VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR = 0x00000001 |
There was a problem hiding this comment.
nit: I'd prefer if this was an actual constant in the code and referenced in the assignment on 520.
There was a problem hiding this comment.
I think this constant should be added to the Vk project, not the Veldrid project.
However, I feel that this would have a large impact.
NeoDemo now works with MoltenVK.
|
NeoDemo is now working. |
|
Hi what is the status of this? Any chance this will be merged soon? Or can I help out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made it possible to build on a Mac.
I also added the initialization process that is now required by the latest MoltenVK.