Fix careercup#218 Arrays and Strings: One away when string are same

vbhosle · Apr 30, 2021 · bb51abf · bb51abf
1 parent 59018cf
commit bb51abf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionA.java b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionA.java
@@ -13,7 +13,7 @@ public static boolean oneEditReplace(String s1, String s2) {
 				foundDifference = true;
 			}
 		}
-		return true;
+		return foundDifference;
 	}
 
 	/* Check if you can insert a character into s1 to make s2. */

diff --git a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionB.java b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/QuestionB.java
@@ -27,7 +27,7 @@ public static boolean oneEditAway(String first, String second) {
 			}
 			index2++; // Always move pointer for longer string 
 		}
-		return true;
+		return foundDifference || (index1 < s1.length() || index2 < s2.length());
 	}
 
 

diff --git a/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/Tester.java b/Java/Ch 01. Arrays and Strings/Q1_05_One_Away/Tester.java
@@ -26,7 +26,8 @@ public static void main(String[] args) {
 				{"adfdsfadsf", "bdfdsfadsg", "false"},
 				{"adfdsfadsf", "affdsfads", "false"},
 				{"pale", "pkle", "true"},
-				{"pkle", "pable", "false"}};
+				{"pkle", "pable", "false"},
+				{"pale", "pale", "false"}};
 		for (int i = 0; i < tests.length; i++) {
 			String[] test = tests[i];
 			String a = test[0];