Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BasicForm): 修复表单项通过ifShow控制隐藏后其表单值还存在 #3836

Closed
wants to merge 1 commit into from

Conversation

zwtvip
Copy link
Contributor

@zwtvip zwtvip commented May 12, 2024

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Member

这个存疑不算bug, 至少在我这边业务场景下, ifshow隐藏后,还需要传值的必要, 先开个issue讨论下吧,记得有类似的issue

@wangjue666 wangjue666 marked this pull request as draft May 13, 2024 02:59
@zwtvip
Copy link
Contributor Author

zwtvip commented May 13, 2024

这个存疑不算bug, 至少在我这边业务场景下, ifshow隐藏后,还需要传值的必要, 先开个issue讨论下吧,记得有类似的issue

@wangjue666 想要隐藏后传值可以用show,ifshow代表不渲染表单项,我的理解是不应该出现这个field

@wangjue666
Copy link
Member

ifshow和show场景 我的用法是在一些自定义组件上,渲染吃力就用ifshow, 可以提个issue再探讨下这个问题~

@wangjue666
Copy link
Member

在formconfig配置项做成一个是否启用的开关,是比较合适的情形,这样对业务侵入性小

@zwtvip zwtvip closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants