Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate uniforms-bridge-graphql package #1322

Merged
merged 3 commits into from
May 24, 2024

Conversation

piotrpospiech
Copy link
Collaborator

@piotrpospiech piotrpospiech commented Apr 20, 2024

Deprecate the GraphQL bridge, as mentioned in this issue (#1315).

  • Removed the whole package from the uniforms repository
  • Removed package from labeler
  • Removed GraphQL from the Readme file
  • Removed graphql and uniforms-bridge-graphql packages from package.json files
  • Removed GraphQL example from docs (playground)
  • Removed bridge from tsconfig references

Note

I left the GraphQLBridge docs. We will keep that in the uniforms v3 docs.

@piotrpospiech piotrpospiech added this to the v4.0 milestone Apr 20, 2024
@piotrpospiech piotrpospiech self-assigned this Apr 20, 2024
@github-actions github-actions bot added Area: Bridge Affects some of the bridge packages Area: Docs Affects the documentation or reproductions seed Area: Infra Affects the repository itself (e.g., CI, dependencies) Bridge: GraphQL Affects the uniforms-bridge-graphql package labels Apr 20, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (4b3f109) to head (c7822ee).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
- Coverage   94.55%   94.47%   -0.09%     
==========================================
  Files         231      229       -2     
  Lines        3823     3730      -93     
  Branches     1030     1002      -28     
==========================================
- Hits         3615     3524      -91     
+ Misses         82       81       -1     
+ Partials      126      125       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kestarumper kestarumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we leave the docs about the GraphQL bridge, shouldn't we add a warning that the package has been deprecated? I suggest using admonition.

@piotrpospiech piotrpospiech merged commit 1436d4c into master May 24, 2024
6 of 7 checks passed
@piotrpospiech piotrpospiech deleted the deprecate-bridge-graphql branch May 24, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Bridge Affects some of the bridge packages Area: Docs Affects the documentation or reproductions seed Area: Infra Affects the repository itself (e.g., CI, dependencies) Bridge: GraphQL Affects the uniforms-bridge-graphql package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants