Add mantine theme #1287
Add mantine theme #1287
Conversation
github-actions
bot
added
the
Area: Infra
github-actions
bot
added
the
Area: Docs
|
Was this abandoned? |
|
No, I will get back to it next week. We must wait for the bump |
| class _ extends parent { | ||
| static Mantine = Mantine; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/restrict-template-expressions -- comes from uniform's core |
There was a problem hiding this comment.
Is this eslint comment needed? I didn't see it previously in other themes.
| parent.onChange(value); | ||
| }} | ||
| > | ||
| <IconTrash size="1rem" color="white" /> |
There was a problem hiding this comment.
In other themes, we have icon props with default value. You did it like this in the ListAddField.
| required={tooltip ? false : required} | ||
| error={showInlineError && !!error && errorMessage} | ||
| > | ||
| <ListMantine listStyleType="none" w="100%" {...filterDOMProps(props)}> |
There was a problem hiding this comment.
You did List as ListMantine, but in RadioField you wrote Radio as MantineRadio. Stick to one convention.
| placeholder={placeholder} | ||
| required={required ?? false} | ||
| defaultValue={[]} | ||
| value={value as string[]} |
There was a problem hiding this comment.
You shouldn't be forced to do that.
| placeholder={placeholder} | ||
| required={required ?? false} | ||
| defaultValue={null} | ||
| value={value as string} |
|
|
||
| return ( | ||
| <Button | ||
| mb="xs" |
There was a problem hiding this comment.
In other themes, we don't add margin to the SubmitField
| ); | ||
| } | ||
|
|
||
| Text.defaultProps = { type: 'text' }; |
There was a problem hiding this comment.
defaultProps is deprecated. Set the default type value when destructuring props.
| placeholder={placeholder} | ||
| readOnly={readOnly} | ||
| ref={inputRef} | ||
| type={type ?? 'text'} |
There was a problem hiding this comment.
Remove it. It should be by default text if not defined.
| ref={inputRef} | ||
| type={type ?? 'text'} | ||
| value={value ?? ''} | ||
| w="100%" |
There was a problem hiding this comment.
Do we have full width by default in other themes? Material theme receives fullWidth from theme props, for example.
| @@ -0,0 +1,30 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
in the multiple files you imported React, but it isn't used
No description provided.