Issue #2552 Skip Executing Actions if the Future is cancelled. #2608
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietrich
requested changes
Jul 28, 2020
There was a problem hiding this comment.
Hi! Thank you for the PR. The implementation looks good to me!
It is a good sign that the unit tests still run ;)
But we need at least one additional unit test in FutureTest that covers the issue #2552. Ideally, you take the example the reporter gave and make a test out of it. Sometimes it is hard to test concurrency. Please take a look at the other tests. If you need help please give me a sign and I will assist you!
Thanks!
Daniel
| @@ -376,6 +376,9 @@ boolean tryComplete(Try<? extends T> value) { | |||
| if (waiters != null) { | |||
| waiters.forEach(this::unlock); | |||
| } | |||
| if(isCancelled()) { | |||
There was a problem hiding this comment.
(I don't want to be a nitpicker but you missed one space if(is... --> if (is...)
|
@charvakcpatel007 add the missed space to this branch so it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2552