Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and Rubocop configuration #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johanhalse
Copy link
Contributor

@johanhalse johanhalse commented Oct 28, 2021

Tolken's dependencies need a facelift! I've gone over and bundle updated the ones that needed updating. That was pretty easy, the tests all run fine.

Rubocop, however.

The old configuration was very prescriptive and onerous. I gave up on trying to get up to date with the twenty million new or renamed cops, and instead replaced the original .rubocop.yml with one that starts with the defaults and adds some tweaks to minimize unnecessary churn. Tests still work fine.

I've also bumped the postgres version used in Travis, and opted for 13.4 which is the latest in the 13 series since 14 was released just a few weeks ago. I changed from using an explicit rvm key on travis to using .ruby-version too, for greater compatibility.

@johanhalse johanhalse force-pushed the update-dependencies branch 3 times, most recently from a596a5f to e3cd211 Compare October 28, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant