Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump actionpack from 5.2.3 to 5.2.5 #153

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps actionpack from 5.2.3 to 5.2.5. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Possible Strong Parameters Bypass in ActionPack There is a strong parameters bypass vector in ActionPack.

Versions Affected: rails <= 6.0.3 Not affected: rails < 4.0.0 Fixed Versions: rails >= 5.2.4.3, rails >= 6.0.3.1

Impact

In some cases user supplied information can be inadvertently leaked from Strong Parameters. Specifically the return value of each, or each_value, or each_pair will return the underlying "untrusted" hash of data that was read from the parameters. Applications that use this return value may be inadvertently use untrusted user input.

Impacted code will look something like this:

def update
  # Attacker has included the parameter: `{ is_admin: true }`
  User.update(clean_up_params)
</tr></table> 

... (truncated)

Patched versions: ~> 5.2.4, >= 5.2.4.3; >= 6.0.3.1 Unaffected versions: < 4.0.0

Sourced from The Ruby Advisory Database.

Ability to forge per-form CSRF tokens given a global CSRF token It is possible to possible to, given a global CSRF token such as the one present in the authenticity_token meta tag, forge a per-form CSRF token for any action for that session.

Versions Affected: rails < 5.2.5, rails < 6.0.4 Not affected: Applications without existing HTML injection vulnerabilities. Fixed Versions: rails >= 5.2.4.3, rails >= 6.0.3.1

Impact

Given the ability to extract the global CSRF token, an attacker would be able to construct a per-form CSRF token for that session.

Workarounds

This is a low-severity security issue. As such, no workaround is necessarily until such time as the application can be upgraded.

Patched versions: ~> 5.2.4, >= 5.2.4.3; >= 6.0.3.1 Unaffected versions: none

Release notes

Sourced from actionpack's releases.

5.2.5

Active Support

  • No changes.

Active Model

  • No changes.

Active Record

  • No changes.

Action View

  • No changes.

Action Pack

  • No changes.

Active Job

  • No changes.

Action Mailer

  • No changes.

Action Cable

  • No changes.

Active Storage

... (truncated)

Commits
  • cb0a558 v5.2.5
  • c1ca9c7 Update Changelog entry for 5.2.4.1 to warn of breaking changes
  • 6de08e5 Merge branch '5-2-sec' into 5-2-stable
  • dc7364b Preparing for 5.2.4.5 release
  • 6d8ed35 Merge branch '5-2-4-4' into 5-2-stable
  • 404ad9e v5.2.4.4
  • abd27d5 Fix test/controller/request_forgery_protection_test.rb failure
  • 97d3432 Skip cookie comma separation test
  • f73d439 Merge pull request #38422 from vipulnsward/fix-wrong-spec
  • 08edf16 Fix "Exception: ActionView::Template::Error: wrong number of arguments (2 for...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [actionpack](https://github.com/rails/rails) from 5.2.3 to 5.2.5. **This update includes security fixes.**
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.1.3.1/actionpack/CHANGELOG.md)
- [Commits](rails/rails@v5.2.3...v5.2.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies security Pull requests that address a security vulnerability labels Mar 29, 2021
@dependabot-preview
Copy link
Contributor Author

Superseded by #159.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/actionpack-5.2.5 branch May 5, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants