Consistent locking when logging to H2 session vsl #4095
+50
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging to the h2 sess vsl is incosistent. It is sometimes done while holding the h2 session mutex, and somtimes without it. This utility function makes sure we take the lock when necessary (when more than 1 stream have been created).
We already call it in 3 other places without holding the lock, this will make it easier to handle locking inside h2h_decode_fini itself.
|
Wouldn't this deserve a separate lock? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some of the logging to the H2 session vsl is done withouth holding the session lock, even when multiple streams are active. This PR is an attempt to make things more consistent in that regard.