Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esi: Add VCL override for esi_include_onerror #4054

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

esi: Add VCL override for esi_include_onerror #4054

wants to merge 1 commit into from

Conversation

dridi
Copy link
Member

@dridi dridi commented Feb 12, 2024

Inspired by the discussion from #4053.

@dridi dridi marked this pull request as ready for review February 12, 2024 09:57
@dridi dridi mentioned this pull request Feb 12, 2024
Closed
@dridi
Copy link
Member Author

dridi commented Feb 12, 2024

Discussion from #4053:

One thing I'm also wondering is whether to always initialize this from the parameter or do that only for req_top (technically, resp_top except that it does not exist) and then inherit the default value from req_top in sub-requests.

@nigoroll nigoroll mentioned this pull request Feb 28, 2024
Merged
@nigoroll
Copy link
Member

nigoroll commented Mar 1, 2024

extra bugwash: after release, add vcl control over all esi feature flags

@dridi dridi marked this pull request as draft March 4, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
b=enhancement c=doc c=varnishd r=trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dridi @nigoroll @bsdphk