vdef: introduce v_counted_by_(field) #4039
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new attribute can be used for flexible arrays to make the compiler smarter: - https://clang.llvm.org/docs/AttributeReference.html#counted-by - https://gcc.gnu.org/pipermail/gcc-patches/2023-August/628459.html This would improve the array bound sanitizer. Note: this has not been tested locally, but this should be safe until a compiler supports it. Once supported, we would detect and make the adjustments as needed. Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
|
I am generally 👍🏽 , this could potentially increase our code quality. BUT
locally installing gcc-trunk and testing the changes should not be asking too much, rather than putting the burdon on a future incarnation of some other maintainer. |
I agree with the reasoning to test it before merge to not uncover work later on, I was partly thinking this could be easily tested in CCI. The attribute is maybe too new. Anyways, thanks, I will look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new attribute can be used for flexible arrays to make the compiler smarter:
This would improve the array bound sanitizer.
Note: this has not been tested locally, but this should be safe until a
compiler supports it. Once supported, we would detect and make the adjustments
as needed.