varnishd: add backend age & reuses to Open & Close #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extra information comes handy when trubleshooting idle timeout from the backend. Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
dridi
requested changes
Oct 24, 2023
Comment on lines
-125
to
+134
| "\t%d %s %s [ %s ]\n" | ||
| "\t| | | |\n" | ||
| "\t| | | +- Optional reason\n" | ||
| "\t| | +------ \"close\" or \"recycle\"\n" | ||
| "\t| +--------- Backend display name\n" | ||
| "\t+------------ Connection file descriptor\n" | ||
| "\t%d %s %s %.6f %ld [ %s ]\n" | ||
| "\t| | | | | |\n" | ||
| "\t| | | | | +- Optional reason\n" | ||
| "\t| | | | +------- Backend reuses\n" | ||
| "\t| | | +------------ Backend age in seconds\n" | ||
| "\t| | +--------------- \"close\" or \"recycle\"\n" | ||
| "\t| +------------------ Backend display name\n" | ||
| "\t+--------------------- Connection file descriptor\n" |
There was a problem hiding this comment.
This is a breaking change, and since we are adding the same fields to two tags, maybe we should limit this to BackendOpen? We can deduce the values for BackendClose anyway based on whether we created a brand new connection or reused one from the pool.
Comment on lines
+110
to
+120
| "\t%d %s %s %s %s %s %s %.6f %ld\n" | ||
| "\t| | | | | | | | |\n" | ||
| "\t| | | | | | | | +- Backend reuses\n" | ||
| "\t| | | | | | | +------ Backend age in seconds\n" | ||
| "\t| | | | | | +--------- \"connect\" or \"reuse\"\n" | ||
| "\t| | | | | +------------ Local port\n" | ||
| "\t| | | | +--------------- Local address\n" | ||
| "\t| | | +------------------ Remote port\n" | ||
| "\t| | +--------------------- Remote address\n" | ||
| "\t| +------------------------ Backend display name\n" | ||
| "\t+--------------------------- Connection file descriptor\n" |
There was a problem hiding this comment.
I think I would rather refer to Connection uses and Connection age (everything is in seconds since 4.0 anyway).
Also, I would probably make these fields optional, they aren't really helpful in the "connect" case.
Comment on lines
+133
to
+138
| vtim_real | ||
| PFD_Age(const struct pfd *p) | ||
| { | ||
| CHECK_OBJ_NOTNULL(p, PFD_MAGIC); | ||
| return (VTIM_real() - p->created); | ||
| } |
There was a problem hiding this comment.
We probably have a now at the call site we can pass here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra information comes handy when trubleshooting idle timeout from the backend.