mgt_main: Preserve VSM after startup panics #4000
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a panic occurs early during the cache process startup, before it starts listening to its CLI, we make sure to bypass MGT exit handlers to preserve the VSM. This restores our ability to perform post-mortem inspections.
|
Turning into a draft, there is more to preserve and I have a working PoC, but no time to work on an actual solution. |
|
👍🏽 on the idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a panic occurs early during the cache process startup, before it starts listening to its CLI, we make sure to bypass MGT exit handlers to preserve the VSM.
This restores our ability to perform post-mortem inspections.